feat: add cidr_list attribute to stackit_public_ip_ranges datasource #1001
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
h3adex
force-pushed
the
feat/add-reabable-ip-list
branch
6 times, most recently
from
4adaf65 to
2eb6163
Compare
|
@h3adex Thanks for the contribution! Can you maybe also adjust the acc tests for this? |
h3adex
force-pushed
the
feat/add-reabable-ip-list
branch
from
2eb6163 to
e8a0d8c
Compare
|
E2E Tests |
Signed-off-by: Mauritz Uphoff <[email protected]>
h3adex
force-pushed
the
feat/add-reabable-ip-list
branch
from
e8a0d8c to
4c00380
Compare
|
This PR was marked as stale after 7 days of inactivity and will be closed after another 7 days of further inactivity. If this PR should be kept open, just add a comment, remove the stale label or push new commits to it. |
marceljk
reviewed
Oct 6, 2025
Comment on lines
+2
to
+7
|
|
||
| locals { | ||
| vpn_cidrs = ["X.X.X.X/32", "X.X.X.X/24"] | ||
| } | ||
|
|
||
| # example usage: allow stackit services and customer vpn cidr to access observability apis |
There was a problem hiding this comment.
PR looks in general good. Only a nitpick, can you adjust the comment like in the suggestion, to separate more between the simple example of the datasource and how it can be used with with locals
Suggested change
| locals { | |
| vpn_cidrs = ["X.X.X.X/32", "X.X.X.X/24"] | |
| } | |
| # example usage: allow stackit services and customer vpn cidr to access observability apis | |
| # example usage: allow stackit services and customer vpn cidr to access observability apis | |
| locals { | |
| vpn_cidrs = ["X.X.X.X/32", "X.X.X.X/24"] | |
| } | |
marceljk
reviewed
Oct 6, 2025
| var apiIpRanges []string | ||
| for _, ipRange := range *publicIpRanges { | ||
| if ipRange.Cidr != nil || *ipRange.Cidr != "" { | ||
| if ipRange.Cidr != nil && *ipRange.Cidr != "" { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR makes working with the datasource easier. Current way to work with it to enable stackit acls for stackit public ranges is this way:
Checklist
make fmtexamples/directory)make generate-docs(will be checked by CI)make test(will be checked by CI)make lint(will be checked by CI)